kangmin/Retribusi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix redirect loop: tambah sessionStorage guard dan path check yang lebih ketat

Browse Source
This commit is contained in:
mwpn
2025-12-18 11:37:54 +07:00
parent d9ab8a1f03
commit 1528559c20
5 changed files with 48 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
public/dashboard/js/api.js
View File

@@ -40,9 +40,11 @@ async function apiRequest(path, options = {}) {
// Unauthorized → clear token & redirect to login
localStorage.removeItem('token');
localStorage.removeItem('user');
sessionStorage.removeItem('auth_redirect_done');
// Cek apakah sudah di login page untuk menghindari redirect loop
const currentPath = window.location.pathname;
if (!currentPath.includes('index.php')) {
const isLoginPage = currentPath.includes('index.php');
if (!isLoginPage) {
window.location.href = '../index.php';
}
throw new Error('Unauthorized');

14
public/dashboard/js/auth.js
View File

@@ -76,10 +76,18 @@ document.addEventListener('DOMContentLoaded', () => {
const form = document.getElementById('login-form');
if (form) {
// Cek apakah sudah authenticated dan belum di dashboard untuk menghindari redirect loop
// Hanya redirect jika benar-benar di login page (bukan dashboard)
const currentPath = window.location.pathname;
if (Auth.isAuthenticated() && !currentPath.includes('dashboard')) {
window.location.href = 'dashboard.html';
return;
const isLoginPage = currentPath.includes('index.php') || (currentPath.endsWith('/') && !currentPath.includes('dashboard'));
const isDashboardPage = currentPath.includes('dashboard.html') || currentPath.includes('event.html') || currentPath.includes('settings.html');
if (Auth.isAuthenticated() && isLoginPage && !isDashboardPage) {
const redirectKey = 'auth_redirect_done';
if (!sessionStorage.getItem(redirectKey)) {
sessionStorage.setItem(redirectKey, '1');
window.location.href = 'dashboard.html';
return;
}
}
form.addEventListener('submit', handleLoginSubmit);
}

12
public/dashboard/js/dashboard.js
View File

@@ -695,9 +695,19 @@ function initCharts() {
document.addEventListener('DOMContentLoaded', async () => {
// Require auth
if (!Auth.isAuthenticated()) {
window.location.href = '../index.php';
// Cek apakah sudah di login page untuk mencegah redirect loop
const currentPath = window.location.pathname;
const isLoginPage = currentPath.includes('index.php');
if (!isLoginPage) {
// Clear redirect flag jika logout
sessionStorage.removeItem('auth_redirect_done');
window.location.href = '../index.php';
}
return;
}
// Clear redirect flag saat sudah di dashboard
sessionStorage.removeItem('auth_redirect_done');
// Set default date ke hari ini (jangan auto-detect ke tanggal lama)
const today = new Date().toISOString().split('T')[0];